Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1134213002: [iOS] Upstream fork in template_url.cc (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream fork in template_url.cc Use the same sourceid (chrome-mobile) for search on Google on Android and iOS. BUG=None Committed: https://crrev.com/7962f36d922c77f234b94a17223aea4d9b7618b8 Cr-Commit-Position: refs/heads/master@{#329618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/search_engines/template_url.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look (downstream has been running with that change since Jan 2013 so ...
5 years, 7 months ago (2015-05-12 15:10:37 UTC) #2
Peter Kasting
LGTM
5 years, 7 months ago (2015-05-12 18:49:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134213002/1
5 years, 7 months ago (2015-05-13 12:33:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 12:37:22 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 12:38:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7962f36d922c77f234b94a17223aea4d9b7618b8
Cr-Commit-Position: refs/heads/master@{#329618}

Powered by Google App Engine
This is Rietveld 408576698