Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: tools/json_schema_compiler/test/idl_basics.idl

Issue 11342033: Allow IDL schemas to have comments on callback functions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clarify comment Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/idl_schema_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/test/idl_basics.idl
diff --git a/tools/json_schema_compiler/test/idl_basics.idl b/tools/json_schema_compiler/test/idl_basics.idl
index eb4ec62ccc158b2845ce8b869d82c364c6719048..f4e1b3ca61262a172fea670d1fb923b44b29ccf5 100644
--- a/tools/json_schema_compiler/test/idl_basics.idl
+++ b/tools/json_schema_compiler/test/idl_basics.idl
@@ -26,6 +26,11 @@
callback Callback3 = void(MyType1 arg);
callback Callback4 = void(MyType2[] arg);
callback Callback5 = void(EnumType type);
+ // A comment on a callback.
+ // |x|: A parameter.
+ callback Callback6 = void(long x);
+ // |x|: Just a parameter comment, with no comment on the callback.
+ callback Callback7 = void(long x);
interface Functions {
static void function1();
@@ -60,6 +65,11 @@
// "switch" is a reserved word and should cause a C++ compile error if we
// emit code for this declaration.
[nocompile] static void function15(long switch);
+
+ static void function16(Callback6 cb);
+ static void function17(Callback7 cb);
+ // |cb|: Override callback comment.
+ static void function18(Callback7 cb);
};
interface Events {
« no previous file with comments | « tools/json_schema_compiler/idl_schema_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698