Fold away x === null comparisons when propagated cid of x is not kDynamicCid.

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "vm/ast_printer.h"
 #include "vm/code_descriptors.h"
 #include "vm/dart_entry.h"
 #include "vm/flags.h"
@@ skipping 1650 matching lines @@
   arguments->Add(push_ctor_arg);
 
   BuildPushArguments(*node->arguments(), arguments);
   Do(new StaticCallInstr(node->token_pos(),
                          node->constructor(),
                          node->arguments()->names(),
                          arguments));
 }
 
 
+static bool IsRecognizedConstructor(const Function& function,
+                                    const String& expected) {
+  const Class& clazz = Class::Handle(function.Owner());
+  const Library& lib = Library::Handle(clazz.library());
+
+  const String& expected_class_name =
+      String::Handle(lib.PrivateName(expected));
+  if (!String::Handle(clazz.Name()).Equals(expected_class_name)) {
+    return false;
+  }
+
+  const String& function_name = String::Handle(function.name());
+  const String& expected_function_name = String::Handle(
+      String::Concat(expected_class_name, String::Handle(Symbols::Dot())));
+  return function_name.Equals(expected_function_name);
+}
+
+
 static intptr_t GetResultCidOfConstructor(ConstructorCallNode* node) {
+  const Function& function = node->constructor();
+  const Class& function_class = Class::Handle(function.Owner());
+  const Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
+
+  if (function_class.library() != core_impl_lib.raw()) {
+    return kDynamicCid;
+  }
+
   if (node->constructor().IsFactory()) {
-    const Function& function = node->constructor();
-    const Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
-    const Class& function_class = Class::Handle(function.Owner());
-
-    if (function_class.library() == core_impl_lib.raw()) {
-      if (function_class.Name() == Symbols::ListImplementation()) {
-        if (function.name() == Symbols::ListFactory()) {
-          if (node->arguments()->length() == 0) {
-            return kGrowableObjectArrayCid;
-          } else {
-            ASSERT(node->arguments()->length() == 1);
-            return kArrayCid;
-          }
-        }
+    if ((function_class.Name() == Symbols::ListImplementation()) &&
+        (function.name() == Symbols::ListFactory())) {
+      // If there are no arguments then the result is guaranteed to be a
+      // GrowableObjectArray. However if there is an argument the result
+      // is not guaranteed to be a fixed size array because the argument
+      // can be null.
+      if (node->arguments()->length() == 0) {
+        return kGrowableObjectArrayCid;
+      }
+    } else {
+      if (IsRecognizedConstructor(function,
+                                  String::Handle(Symbols::ObjectArray())) &&
+          (node->arguments()->length() == 1)) {
+        return kArrayCid;
+      } else if (IsRecognizedConstructor(function,
+                     String::Handle(Symbols::GrowableObjectArray())) &&
+                 (node->arguments()->length() == 0)) {
+        return kGrowableObjectArrayCid;
       }
     }
   }
   return kDynamicCid;   // Result cid not known.
 }
 
 
 void EffectGraphVisitor::VisitConstructorCallNode(ConstructorCallNode* node) {
   if (node->constructor().IsFactory()) {
     ZoneGrowableArray<PushArgumentInstr*>* arguments =
@@ skipping 1119 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, function_name, reason) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, function_name, reason);
   const Error& error = Error::Handle(
       LanguageError::New(String::Handle(String::New(chars))));
   Isolate::Current()->long_jump_base()->Jump(1, error);
 }
 
 
 }  // namespace dart