Issue 1134193003: Avoid renderer kills on subframe navigations after main frame replaceState.

Issue 1134193003: Avoid renderer kills on subframe navigations after main frame replaceState. (Closed)

Created:
5 years, 7 months ago by Charlie Reis

Modified:
5 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Avoid renderer kills on subframe navigations after main frame replaceState. BUG=486916 TEST=See bug comment 1 for repro steps. Committed: https://crrev.com/11c5ff87774c88b785065f0d74681c5a867026bf Cr-Commit-Position: refs/heads/master@{#329440}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -3 lines)			Patch
	M	content/browser/frame_host/navigation_controller_impl.cc	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	content/browser/frame_host/navigation_controller_impl_browsertest.cc	View		1 chunk	+52 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

Charlie Reis

Avi, can you take a look? Hopefully this resolves the renderer kills we're seeing in ...

5 years, 7 months ago (2015-05-12 17:13:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134193003/1

5 years, 7 months ago (2015-05-12 17:23:40 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-12 18:07:50 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/11c5ff87774c88b785065f0d74681c5a867026bf
Cr-Commit-Position: refs/heads/master@{#329440}