Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 1134193002: Provide accessor for object internal properties that doesn't require debugger to be active (Closed)

Created:
5 years, 7 months ago by yurys
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev, Paweł Hajdan Jr., sergeyv
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide accessor for object internal properties that doesn't require debugger to be active Some of the DevTools' clients need to inspect JS objects without enabling debugger. This CL allows to inspect object's internal properties without enabling debugger and instantiating debug context. Note that now debug context can be created lazily if v8::Debug::GetDebugContext is called when there is no debug listener. This is fragile and has already resulted in some subtle error. I'm going to fix that in a separate CL. BUG=chromium:481845 LOG=Y Committed: https://crrev.com/ae6ec1861e7184bce4f45f73db6af355944ef58f Cr-Commit-Position: refs/heads/master@{#28371}

Patch Set 1 #

Patch Set 2 : Fixed gcmole failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -60 lines) Patch
M include/v8-debug.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/contexts.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/mirror-debugger.js View 1 chunk +5 lines, -50 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 1 chunk +177 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yurys
This is exact copy of https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d with fix for gcmole applied in PS#2
5 years, 7 months ago (2015-05-12 15:00:43 UTC) #2
Yang
On 2015/05/12 15:00:43, yurys wrote: > This is exact copy of https://crrev.com/bdeb0de88c8cf5f2c78f261b45314138f525110d > with fix ...
5 years, 7 months ago (2015-05-12 15:02:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134193002/20001
5 years, 7 months ago (2015-05-12 15:03:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 15:40:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 15:40:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ae6ec1861e7184bce4f45f73db6af355944ef58f
Cr-Commit-Position: refs/heads/master@{#28371}

Powered by Google App Engine
This is Rietveld 408576698