Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1134183004: Chromecast: adds CastMetricsHelper API from Java. (Closed)

Created:
5 years, 7 months ago by gunsch
Modified:
5 years, 7 months ago
Reviewers:
lcwu1, byungchul
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds CastMetricsHelper API from Java. R=byungchul@chromium.org,lcwu@chromium.org BUG=internal b/21262248 Committed: https://crrev.com/602004df17bfd877f8ff5bb7d7a9665ab992a7c4 Cr-Commit-Position: refs/heads/master@{#330556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M chromecast/android/cast_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A chromecast/android/cast_metrics_helper_android.h View 1 chunk +26 lines, -0 lines 0 comments Download
A chromecast/android/cast_metrics_helper_android.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastMetricsHelper.java View 1 chunk +25 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
gunsch
5 years, 7 months ago (2015-05-18 18:34:04 UTC) #1
byungchul
lgtm
5 years, 7 months ago (2015-05-18 22:12:14 UTC) #2
lcwu1
lgtm
5 years, 7 months ago (2015-05-19 16:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134183004/1
5 years, 7 months ago (2015-05-19 17:38:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 18:06:26 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 18:07:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/602004df17bfd877f8ff5bb7d7a9665ab992a7c4
Cr-Commit-Position: refs/heads/master@{#330556}

Powered by Google App Engine
This is Rietveld 408576698