Source/core/dom/shadow/ShadowRoot.cpp - Issue 1134173002: Get rid of TreeBoundaryCrossingRules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 1134173002: Get rid of TreeBoundaryCrossingRules. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Missing resolver decrement and adjusted test. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp

index 79445bdca87a62a1c8755efad57944da994e67ca..cc11940754493fe7b35824095abace4819567909 100644

--- a/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/Source/core/dom/shadow/ShadowRoot.cpp

@@ -155,6 +155,12 @@ void ShadowRoot::attach(const AttachContext& context)

DocumentFragment::attach(context);

}

+void ShadowRoot::detach(const AttachContext& context)

+ TreeScope::clearComposedParent();

+ DocumentFragment::detach(context);

Node::InsertionNotificationRequest ShadowRoot::insertedInto(ContainerNode* insertionPoint)

{

DocumentFragment::insertedInto(insertionPoint);