Issue 1134153003: Cleanup base/logging.cc a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134153003: Cleanup base/logging.cc a bit. (Closed)

Created:
5 years, 7 months ago by Lei Zhang

Modified:
5 years, 7 months ago

Reviewers:
danakj

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Cleanup base/logging.cc a bit. - NULL -> nullptr - prepend g_ to global variables - fix misc nits. Committed: https://crrev.com/3e4787d6fe8c22a59c02cb84c03c9f6adde10a83 Cr-Commit-Position: refs/heads/master@{#330582}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -83 lines)			Patch
	M	base/logging.cc	View	1	24 chunks	+83 lines, -83 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134153003/20001

5 years, 7 months ago (2015-05-19 18:18:46 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 19:32:57 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3e4787d6fe8c22a59c02cb84c03c9f6adde10a83
Cr-Commit-Position: refs/heads/master@{#330582}