Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1134123004: Omnibox - Use Case Insensitive Matching when Bolding Query Suggestions (Closed)

Created:
5 years, 7 months ago by Mark P
Modified:
5 years, 7 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omnibox - Use Case Insensitive Matching when Bolding Query Suggestions BUG=228694 Committed: https://crrev.com/c947c40710fed9381248449a1a40ced4084dcc4f Cr-Commit-Position: refs/heads/master@{#329298}

Patch Set 1 #

Patch Set 2 : remove extra include #

Total comments: 2

Patch Set 3 : wchar->char16 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/omnibox/search_suggestion_parser.cc View 1 2 4 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mark P
Please take a look, thanks.
5 years, 7 months ago (2015-05-11 23:18:11 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/1134123004/diff/20001/components/omnibox/search_suggestion_parser.cc File components/omnibox/search_suggestion_parser.cc (right): https://codereview.chromium.org/1134123004/diff/20001/components/omnibox/search_suggestion_parser.cc#newcode160 components/omnibox/search_suggestion_parser.cc:160: lookup_text.end(), base::CaseInsensitiveCompare<wchar_t>()); wchar_t seems wrong, shouldn't it be ...
5 years, 7 months ago (2015-05-11 23:40:37 UTC) #3
Mark P
https://codereview.chromium.org/1134123004/diff/20001/components/omnibox/search_suggestion_parser.cc File components/omnibox/search_suggestion_parser.cc (right): https://codereview.chromium.org/1134123004/diff/20001/components/omnibox/search_suggestion_parser.cc#newcode160 components/omnibox/search_suggestion_parser.cc:160: lookup_text.end(), base::CaseInsensitiveCompare<wchar_t>()); On 2015/05/11 23:40:37, Peter Kasting wrote: > ...
5 years, 7 months ago (2015-05-11 23:45:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134123004/40001
5 years, 7 months ago (2015-05-11 23:49:14 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 00:36:44 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 00:37:40 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c947c40710fed9381248449a1a40ced4084dcc4f
Cr-Commit-Position: refs/heads/master@{#329298}

Powered by Google App Engine
This is Rietveld 408576698