Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1134113007: Revert of Moves SQLitePersistentCookieStore to net/extras/sqlite. (Closed)

Created:
5 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 7 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@cookies
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Moves SQLitePersistentCookieStore to net/extras/sqlite. (patchset #25 id:470001 of https://codereview.chromium.org/1016643004/) Reason for revert: Seems to break content_unittests QuotaPolicyCookieStoreTest.TestPolicy. See https://build.chromium.org/p/chromium.webrtc/builders/Win7%20Tester for details. Reverting to see if the bot turns green again. I am unable to find any other CL that can cause this. Original issue's description: > Moves SQLitePersistentCookieStore to net/extras/sqlite. > > The application of special storage policy is split out into a new class, > QuotaPolicyCookieStore, in content/browser/net. > > BUG=467596 > TEST=No visible impact. > > Committed: https://crrev.com/57adf29fb4e46a49272610140b097f85e1e805f5 > Cr-Commit-Position: refs/heads/master@{#329950} TBR=rsleevi@chromium.org,mef@chromium.org,nharper@chromium.org,avi@chromium.org,rohitrao@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467596 Committed: https://crrev.com/ac4f49641d2b1246fdcfdb35993b21200d43460f Cr-Commit-Position: refs/heads/master@{#330075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2371 lines, -2771 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/browser/net/quota_policy_cookie_store.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/browser/net/quota_policy_cookie_store.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D content/browser/net/quota_policy_cookie_store_unittest.cc View 1 chunk +0 lines, -244 lines 0 comments Download
A content/browser/net/sqlite_persistent_cookie_store.h View 1 chunk +79 lines, -0 lines 0 comments Download
A content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +1465 lines, -0 lines 0 comments Download
A content/browser/net/sqlite_persistent_cookie_store_perftest.cc View 1 chunk +141 lines, -0 lines 0 comments Download
A content/browser/net/sqlite_persistent_cookie_store_unittest.cc View 1 chunk +681 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 3 chunks +2 lines, -2 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D net/extras/sqlite/sqlite_persistent_cookie_store.h View 1 chunk +0 lines, -73 lines 0 comments Download
D net/extras/sqlite/sqlite_persistent_cookie_store.cc View 1 chunk +0 lines, -1366 lines 0 comments Download
D net/extras/sqlite/sqlite_persistent_cookie_store_perftest.cc View 1 chunk +0 lines, -141 lines 0 comments Download
D net/extras/sqlite/sqlite_persistent_cookie_store_unittest.cc View 1 chunk +0 lines, -663 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M net/net.gypi View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Moves SQLitePersistentCookieStore to net/extras/sqlite.
5 years, 7 months ago (2015-05-15 11:12:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134113007/1
5 years, 7 months ago (2015-05-15 11:12:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 11:13:33 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 11:14:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac4f49641d2b1246fdcfdb35993b21200d43460f
Cr-Commit-Position: refs/heads/master@{#330075}

Powered by Google App Engine
This is Rietveld 408576698