views: Rename IDR_INFOBARBUTTON_<POSITION>_<STATE> to IDR_INFOBARBUTTON_<STATE>_<POSITION>.

views: Rename IDR_INFOBARBUTTON_<POSITION>_<STATE> to IDR_INFOBARBUTTON_<STATE>_<POSITION>.

To match IDR_TEXTBUTTON_*_*.

R=msw@chromium.org
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165413

[tfarina, 2012-10-30 22:33:25]

Hi Mike, please review this to me.

[msw, 2012-10-30 22:47:06]

https://codereview.chromium.org/11341049/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/11341049/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:331: <structure type="chrome_scaled_image"
name="IDR_INFOBARBUTTON_HOVER_BOTTOM" file="infobarbutton_b_hover.png" />
Please alphabetize these by IDR name.

https://codereview.chromium.org/11341049/diff/1/chrome/browser/ui/views/infob...
File chrome/browser/ui/views/infobars/infobar_button_border.cc (right):

https://codereview.chromium.org/11341049/diff/1/chrome/browser/ui/views/infob...
chrome/browser/ui/views/infobars/infobar_button_border.cc:11: #define
BORDER_IMAGES(x, y) \
Remove this and expose/use BORDER_IMAGES(IDR_INFOBARBUTTON_<STATE>) from
ui/views/controls/button/border_images.h
(I'd prefer to keep that macro to 3 lines with visual ordering)

[tfarina, 2012-10-30 22:53:56]

https://codereview.chromium.org/11341049/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/11341049/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:331: <structure type="chrome_scaled_image"
name="IDR_INFOBARBUTTON_HOVER_BOTTOM" file="infobarbutton_b_hover.png" />
On 2012/10/30 22:47:06, msw wrote:
> Please alphabetize these by IDR name.

Done.

https://codereview.chromium.org/11341049/diff/1/chrome/browser/ui/views/infob...
File chrome/browser/ui/views/infobars/infobar_button_border.cc (right):

https://codereview.chromium.org/11341049/diff/1/chrome/browser/ui/views/infob...
chrome/browser/ui/views/infobars/infobar_button_border.cc:11: #define
BORDER_IMAGES(x, y) \
On 2012/10/30 22:47:06, msw wrote:
> Remove this and expose/use BORDER_IMAGES(IDR_INFOBARBUTTON_<STATE>) from
> ui/views/controls/button/border_images.h
> (I'd prefer to keep that macro to 3 lines with visual ordering)

Done.

[msw, 2012-10-30 22:59:47]

LGTM; thanks!

https://codereview.chromium.org/11341049/diff/6001/ui/views/controls/button/b...
File ui/views/controls/button/border_images.h (right):

https://codereview.chromium.org/11341049/diff/6001/ui/views/controls/button/b...
ui/views/controls/button/border_images.h:14: namespace gfx {
nit: add a blank line above.

[tfarina, 2012-10-30 23:44:19]

TBRing Scott for owners approval.

https://codereview.chromium.org/11341049/diff/6001/ui/views/controls/button/b...
File ui/views/controls/button/border_images.h (right):

https://codereview.chromium.org/11341049/diff/6001/ui/views/controls/button/b...
ui/views/controls/button/border_images.h:14: namespace gfx {
On 2012/10/30 22:59:47, msw wrote:
> nit: add a blank line above.

Done.