Chromium Code Reviews| Index: sync/internal_api/sync_manager_impl.h |
| diff --git a/sync/internal_api/sync_manager_impl.h b/sync/internal_api/sync_manager_impl.h |
| index 53b882e6177cf5d5ad7bce387d37865a6df23090..e92e334376842861ce9a31b5d666988ce7e9f4c4 100644 |
| --- a/sync/internal_api/sync_manager_impl.h |
| +++ b/sync/internal_api/sync_manager_impl.h |
| @@ -163,10 +163,12 @@ class SyncManagerImpl : public SyncManager, |
| syncable::BaseTransaction* trans) OVERRIDE; |
| virtual void HandleCalculateChangesChangeEventFromSyncApi( |
| const syncable::ImmutableWriteTransactionInfo& write_transaction_info, |
| - syncable::BaseTransaction* trans) OVERRIDE; |
| + syncable::BaseTransaction* trans, |
| + std::vector<int64>* entry_changed) OVERRIDE; |
|
tim (not reviewing)
2012/11/08 17:38:49
entries_changed is more accurate, I think?
haitaol1
2012/11/08 19:06:53
Done.
|
| virtual void HandleCalculateChangesChangeEventFromSyncer( |
| const syncable::ImmutableWriteTransactionInfo& write_transaction_info, |
| - syncable::BaseTransaction* trans) OVERRIDE; |
| + syncable::BaseTransaction* trans, |
| + std::vector<int64>* entry_changed) OVERRIDE; |
| // InvalidationHandler implementation. |
| virtual void OnInvalidatorStateChange(InvalidatorState state) OVERRIDE; |
| @@ -221,8 +223,6 @@ class SyncManagerImpl : public SyncManager, |
| const syncable::EntryKernelMutation& mutation, |
| Cryptographer* cryptographer) const; |
| - bool ChangeBuffersAreEmpty(); |
| - |
| // Open the directory named with username_for_share |
| bool OpenDirectory(); |
| @@ -329,13 +329,14 @@ class SyncManagerImpl : public SyncManager, |
| // sync components. |
| AllStatus allstatus_; |
| - // Each element of this array is a store of change records produced by |
| - // HandleChangeEvent during the CALCULATE_CHANGES step. The changes are |
| - // segregated by model type, and are stored here to be processed and |
| - // forwarded to the observer slightly later, at the TRANSACTION_ENDING |
| - // step by HandleTransactionEndingChangeEvent. The list is cleared in the |
| - // TRANSACTION_COMPLETE step by HandleTransactionCompleteChangeEvent. |
| - ChangeReorderBuffer change_buffers_[MODEL_TYPE_COUNT]; |
| + // Each element of this map is a store of change records produced by |
| + // HandleChangeEventFromSyncer during the CALCULATE_CHANGES step. The changes |
| + // are grouped by model type, and are stored here in tree order to be |
| + // forwarded to the observer slightly later, at the TRANSACTION_ENDING step |
| + // by HandleTransactionEndingChangeEvent. The list is cleared after observer |
| + // finishes processing. |
| + typedef std::map<int, ImmutableChangeRecordList> ChangeRecordMap; |
| + ChangeRecordMap change_records_; |
| SyncManager::ChangeDelegate* change_delegate_; |