Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1134093003: Make Porter Duff LCD XP its own XferProcessor (Closed)

Created:
5 years, 7 months ago by egdaniel
Modified:
5 years, 7 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make Porter Duff LCD XP its own XferProcessor BUG=skia: Committed: https://skia.googlesource.com/skia/+/0d5fd110e0b7ce9b892833d874145a79ca67da8d

Patch Set 1 #

Patch Set 2 : update #

Total comments: 1

Patch Set 3 : Review update #

Patch Set 4 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -26 lines) Patch
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 3 3 chunks +127 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
egdaniel
5 years, 7 months ago (2015-05-11 20:35:39 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1134093003/diff/20001/src/gpu/effects/GrPorterDuffXferProcessor.cpp File src/gpu/effects/GrPorterDuffXferProcessor.cpp (right): https://codereview.chromium.org/1134093003/diff/20001/src/gpu/effects/GrPorterDuffXferProcessor.cpp#newcode680 src/gpu/effects/GrPorterDuffXferProcessor.cpp:680: if (!covPOI.isFourChannelOutput()) { reverse this? if (isfour) { ...
5 years, 7 months ago (2015-05-11 20:58:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134093003/40001
5 years, 7 months ago (2015-05-12 13:00:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/995)
5 years, 7 months ago (2015-05-12 13:01:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134093003/60001
5 years, 7 months ago (2015-05-12 13:05:34 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 13:11:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0d5fd110e0b7ce9b892833d874145a79ca67da8d

Powered by Google App Engine
This is Rietveld 408576698