Issue 113409: Modify assert so it doesn't crash when 'location' is NULL....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113409: Modify assert so it doesn't crash when 'location' is NULL.... (Closed)

Created:
11 years, 7 months ago by Sverrir

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Modify assert so it doesn't crash when 'location' is NULL. Saw this when testing the new printing code (not checked in yet).

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/handles-inl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sverrir

Hej Mads, Got the first assert and when I continued the browser crashed since its ...

11 years, 7 months ago (2009-05-14 19:34:45 UTC) #1

Mads Ager (chromium)

11 years, 7 months ago (2009-05-15 06:13:09 UTC) #2

As Søren and Kevin replied, dereferencing a null handle is going to crash
anyway, so I'd like to keep this a two separate ASSERTS so it is easy to see
which one of the conjuncts gets hit.

Expand Messages | Collapse Messages