Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1134043002: Handle imc_handle_for_renderer error properly. (Closed)

Created:
5 years, 7 months ago by hidehiko
Modified:
5 years, 7 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, hamaji, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle imc_handle_for_renderer error properly. As Mark pointed in https://codereview.chromium.org/1094653003/diff/220001/components/nacl/browser/nacl_process_host.cc#newcode746, error handling for imc_handle_for_renderer is missing. This CL fixes it. TEST=Ran bots. BUG=358417 Committed: https://crrev.com/e53dd896e4580a2854844281d830678613d8fd3c Cr-Commit-Position: refs/heads/master@{#329149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M components/nacl/browser/nacl_process_host.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hidehiko
PTAL.
5 years, 7 months ago (2015-05-11 12:09:11 UTC) #2
Mark Seaborn
LGTM, thanks
5 years, 7 months ago (2015-05-11 14:04:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134043002/1
5 years, 7 months ago (2015-05-11 14:05:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 14:08:42 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 14:10:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e53dd896e4580a2854844281d830678613d8fd3c
Cr-Commit-Position: refs/heads/master@{#329149}

Powered by Google App Engine
This is Rietveld 408576698