Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 113403006: Update some uses of char16 to use the base:: namespace. (Closed)

Created:
6 years, 12 months ago by Avi (use Gerrit)
Modified:
6 years, 12 months ago
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), aboxhall+watch_chromium.org, skanuj+watch_chromium.org, sadrul, yusukes+watch_chromium.org, jbauman+watch_chromium.org, dhollowa+watch_chromium.org, rpetterson, Michael van Ouwerkerk, browser-components-watch_chromium.org, dcheng, frankf, yukishiino+watch_chromium.org, dgrogan, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, Ilya Sherman, miu+watch_chromium.org, extensions-reviews_chromium.org, benquan, melevin+watch_chromium.org, estade+watch_chromium.org, benjhayden+dwatch_chromium.org, grt+watch_chromium.org, jam, dyu1, dominich, nona+watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, alecflett, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, dougw+watch_chromium.org, dtseng+watch_chromium.org, creis+watch_chromium.org, samarth+watch_chromium.org, yoshiki+watch_chromium.org, rouslan+spellwatch_chromium.org, yuzo+watch_chromium.org, cmumford, jochen+watch_chromium.org, jfweitz+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org, robertshield, penghuang+watch_chromium.org, jsbell, plundblad+watch_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, chrisgao (Use stgao instead), amit, tommycli, joi+watch-content_chromium.org, David Black, Dane Wallinga, Greg Billock, kmadhusu+watch_chromium.org, danakj+watch_chromium.org, James Su, ben+ash_chromium.org
Visibility:
Public.

Description

Update some uses of char16 to use the base:: namespace. BUG=329295 TEST=no change TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -297 lines) Patch
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_input.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/shortcuts_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/background_downloader_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/download/download_query_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/drive_api_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_error_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/in_memory_url_index_types.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/url_index_private_data.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_operations_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/portable_device_watcher_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/storage_monitor/removable_device_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/removable_device_constants.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/storage_monitor_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/storage_monitor/test_portable_device_watcher_win.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/storage_monitor/test_portable_device_watcher_win.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/term_break_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/term_break_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/usb/usb_device_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/ie_importer_utils_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/pepper/ppb_pdf_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/custom_dictionary_engine_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_language.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_language.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/key_converter.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/key_converter_unittest.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/keycode_text_conversion_x.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome_frame/simple_resource_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/win/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/address.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_number.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M components/policy/core/common/preg_parser_win.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M components/sessions/serialized_navigation_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/webdata/encryptor/encryptor_unittest.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/session_storage_database.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/dom_storage/session_storage_database_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/wifi_data_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding.cc View 5 chunks +20 lines, -18 lines 0 comments Download
M content/browser/indexed_db/indexed_db_leveldb_coding_unittest.cc View 5 chunks +15 lines, -15 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/webui/web_ui_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/android/address_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/address_parser_internal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/android/address_parser_internal.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M content/common/dom_storage/dom_storage_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/dom_storage/dom_storage_map_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M content/common/indexed_db/indexed_db_key_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/page_state_serialization.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M content/common/plugin_constants_win.h View 1 chunk +20 lines, -20 lines 0 comments Download
M content/common/plugin_constants_win.cc View 1 chunk +20 lines, -19 lines 0 comments Download
M content/common/plugin_list_win.cc View 2 chunks +15 lines, -15 lines 0 comments Download
M content/common/sandbox_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/address_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Avi (use Gerrit)
6 years, 12 months ago (2013-12-25 20:05:02 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r242503 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698