Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1134013004: Rerun reproduce.sh and pick up some missing elements with git add -f. (Closed)

Created:
5 years, 7 months ago by Jeremy Klein
Modified:
5 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rerun reproduce.sh and pick up some missing elements with git add -f. BUG= Committed: https://crrev.com/398fba3c77f494070fffeb2da56cbae28048b39d Cr-Commit-Position: refs/heads/master@{#329596}

Patch Set 1 #

Patch Set 2 : Lots of small fixes to help wire things together for the 0.8 upgrade. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+971 lines, -25 lines) Patch
M chrome/browser/resources/md_settings/md_settings.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/prefs/prefs.js View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engines_page.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.html View 1 2 chunks +4 lines, -14 lines 0 comments Download
M chrome/browser/resources/settings/settings_main/settings_main.js View 1 4 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/polymer/v0_8/components-chromium/iron-menu-behavior/.bower.json View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/iron-menu-behavior/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/iron-menu-behavior/bower.json View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/iron-menu-behavior/index.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/iron-menu-behavior/iron-menu-behavior.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/iron-menu-behavior/iron-menu-behavior-extracted.js View 1 chunk +121 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-icon-button/.bower.json View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-icon-button/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-icon-button/bower.json View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-icon-button/index.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-icon-button/paper-icon-button.html View 1 chunk +96 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-icon-button/paper-icon-button-extracted.js View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components-chromium/paper-item/.bower.json View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/iron-menu-behavior/.bower.json View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/iron-menu-behavior/README.md View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/iron-menu-behavior/bower.json View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/iron-menu-behavior/index.html View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/iron-menu-behavior/iron-menu-behavior.html View 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-icon-button/.bower.json View 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-icon-button/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-icon-button/bower.json View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-icon-button/index.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/polymer/v0_8/components/paper-icon-button/paper-icon-button.html View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jeremy Klein
5 years, 7 months ago (2015-05-13 06:20:36 UTC) #2
Jeremy Klein
5 years, 7 months ago (2015-05-13 06:20:48 UTC) #4
michaelpg
whoops, looking back at my paper-icon-button CL there was like nothing in it haha. It's ...
5 years, 7 months ago (2015-05-13 06:29:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134013004/1
5 years, 7 months ago (2015-05-13 06:32:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 06:40:00 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 06:40:50 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/398fba3c77f494070fffeb2da56cbae28048b39d
Cr-Commit-Position: refs/heads/master@{#329596}

Powered by Google App Engine
This is Rietveld 408576698