base/process_util_posix.cc - Issue 11340054: Band-aid fix for test hangs:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/process_util_posix.cc

Issue 11340054: Band-aid fix for test hangs: (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: simpler Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/process_util_posix.cc

diff --git a/base/process_util_posix.cc b/base/process_util_posix.cc

index 6d41fe6cd66c034a26ce80848af7bdc76051eabd..96fabf749944d43cbf64079071c26c1f2f584fc1 100644

--- a/base/process_util_posix.cc

+++ b/base/process_util_posix.cc

@@ -141,8 +141,11 @@ void StackDumpSignalHandler(int signal, siginfo_t* info, ucontext_t* context) {

if (debug::BeingDebugged())

debug::BreakDebugger();

+#if defined(OS_MACOSX)

+ // TODO(phajdan.jr): Fix hangs caused by using malloc below.

Scott Hess - ex-Googler 2012/10/30 23:59:55 Ref a tracking bug for this, and maybe s/malloc/tc

DLOG(ERROR) << "Received signal " << signal;

debug::StackTrace().PrintBacktrace();

+#endif

// TODO(shess): Port to Linux.

#if defined(OS_MACOSX)

« no previous file with comments | « no previous file | no next file » | no next file with comments »