Move CopyFileHierarchy to a common test namespace and also use it in MoveTreeWorkItemTest.MoveDirec…

Move CopyFileHierarchy to a common test namespace and also use it in MoveTreeWorkItemTest.MoveDirectoryDestExistsCheckForDuplicatesFull.

Unflakes that test.

TBR=thakis@chromium.org (for chrome\chrome_installer.gypi).
BUG=156374
TEST=installer_util_unittests.exe (ran all of them to make sure no other test was affected)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165962

[grt (UTC plus 2), 2012-10-31 17:33:06]

lgtm w/ two small suggestions

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/dupl...
File chrome/installer/util/duplicate_tree_detector_unittest.cc (right):

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/dupl...
chrome/installer/util/duplicate_tree_detector_unittest.cc:147:
installer::test::CopyFileHierarchy(source_file, dest_file);
ASSERT_TRUE here, too (to preserve previous behavior)?

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/move...
File chrome/installer/util/move_tree_work_item_unittest.cc (right):

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/move...
chrome/installer/util/move_tree_work_item_unittest.cc:410:
file_util::CreateDirectory(to_dir);
is it equivalent to replace 410-414 with:
  // Create a sub-directory identical to the one in the source directory.
  installer::test::CopyFileHierarchy(from_dir1, to_dir);

[gab, 2012-11-01 15:52:05]

Thanks,

TBR: thakis@ for chrome\chrome_installer.gypi file addition.

Gab

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/dupl...
File chrome/installer/util/duplicate_tree_detector_unittest.cc (right):

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/dupl...
chrome/installer/util/duplicate_tree_detector_unittest.cc:147:
installer::test::CopyFileHierarchy(source_file, dest_file);
On 2012/10/31 17:33:06, grt wrote:
> ASSERT_TRUE here, too (to preserve previous behavior)?

Indeed, thanks, done.

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/move...
File chrome/installer/util/move_tree_work_item_unittest.cc (right):

https://codereview.chromium.org/11340049/diff/3001/chrome/installer/util/move...
chrome/installer/util/move_tree_work_item_unittest.cc:410:
file_util::CreateDirectory(to_dir);
On 2012/10/31 17:33:06, grt wrote:
> is it equivalent to replace 410-414 with:
>   // Create a sub-directory identical to the one in the source directory.
>   installer::test::CopyFileHierarchy(from_dir1, to_dir);

Yep, done.

[commit-bot: I haz the power, 2012-11-01 15:52:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11340049/7001

[commit-bot: I haz the power, 2012-11-01 15:52:42]

Presubmit check for 11340049-7001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[commit-bot: I haz the power, 2012-11-01 15:53:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11340049/7001

[commit-bot: I haz the power, 2012-11-01 15:53:34]

Presubmit check for 11340049-7001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 3.8s to calculate.

[commit-bot: I haz the power, 2012-11-01 15:54:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11340049/7001

[commit-bot: I haz the power, 2012-11-01 16:50:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[Nico, 2012-11-01 17:44:03]

gypi change lgtm

[commit-bot: I haz the power, 2012-11-02 12:55:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11340049/9003

[commit-bot: I haz the power, 2012-11-02 14:56:47]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-05 14:11:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11340049/9003

[commit-bot: I haz the power, 2012-11-05 17:02:32]

Retried try job too often for step(s) content_browsertests

[commit-bot: I haz the power, 2012-11-05 17:18:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/11340049/9003

[commit-bot: I haz the power, 2012-11-05 18:21:02]

Change committed as 165962