runtime/vm/thread_pool.cc - Issue 1134003005: Automatic thread cleanup on non-Windows platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/thread_pool.cc

Issue 1134003005: Automatic thread cleanup on non-Windows platforms. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/thread_pool.cc

===================================================================

--- runtime/vm/thread_pool.cc (revision 45808)

+++ runtime/vm/thread_pool.cc (working copy)

@@ -274,11 +274,8 @@

// Release monitor while handling the task.

monitor_.Exit();

- Thread::EnsureInit();

task->Run();

ASSERT(Isolate::Current() == NULL);

- // Prevent unintended sharing of state between tasks.

- Thread::CleanUp();

delete task;

monitor_.Enter();

@@ -333,6 +330,9 @@

ml.Notify();

}

delete worker;

+#if defined(TARGET_OS_WINDOWS)

+ Thread::CleanUp();

+#endif

}

} // namespace dart

« runtime/vm/thread.cc ('K') | « runtime/vm/thread.cc ('k') | no next file » | no next file with comments »