Automatic thread cleanup on non-Windows platforms.

Automatic thread cleanup on non-Windows platforms.

Issue 23474 is tracking Windows support (use Chromium's method).

BUG=23474
R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=45817

[Ivan Posva, 2015-05-15 15:40:52]

LGTM with comments.

-Ivan

https://codereview.chromium.org/1134003005/diff/20001/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/1134003005/diff/20001/runtime/vm/thread.cc#ne...
runtime/vm/thread.cc:57: EnsureInit();
How about initializing once in the thread pool and only asserting here? Then we
only need to ensure the thread is initialized when calling Dart_EnterIsolatem
(and friends) through the C API.

At the extreme you could have Thread::Current() assert that a thread is set. And
use a private Thread::CurrentNoCheck() to build the EnsureInit functionality.

https://codereview.chromium.org/1134003005/diff/20001/runtime/vm/thread.cc#ne...
runtime/vm/thread.cc:97: EnsureInit();
ditto

[koda, 2015-05-15 17:30:04]

https://codereview.chromium.org/1134003005/diff/20001/runtime/vm/thread.cc
File runtime/vm/thread.cc (right):

https://codereview.chromium.org/1134003005/diff/20001/runtime/vm/thread.cc#ne...
runtime/vm/thread.cc:57: EnsureInit();
On 2015/05/15 15:40:52, Ivan Posva wrote:
> How about initializing once in the thread pool and only asserting here? Then
we
> only need to ensure the thread is initialized when calling Dart_EnterIsolatem
> (and friends) through the C API.
> 
> At the extreme you could have Thread::Current() assert that a thread is set.
And
> use a private Thread::CurrentNoCheck() to build the EnsureInit functionality.

Done (but not to the extreme).

https://codereview.chromium.org/1134003005/diff/20001/runtime/vm/thread.cc#ne...
runtime/vm/thread.cc:97: EnsureInit();
On 2015/05/15 15:40:52, Ivan Posva wrote:
> ditto

Done.

[koda, 2015-05-15 17:30:50]

Committed patchset #3 (id:40001) manually as r45817 (presubmit successful).