Issue 1134003004: mandoline/omnibox: Add some opacity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134003004: mandoline/omnibox: Add some opacity. (Closed)

Created:
5 years, 7 months ago by sadrul

Modified:
5 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

mandoline/omnibox: Add some opacity. Add a black translucent background for the omnibox app. BUG=487423 Committed: https://crrev.com/246205e6541383ed6bc431e5f1fdcde8db9e2811 Cr-Commit-Position: refs/heads/master@{#330130}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	mandoline/ui/omnibox/omnibox_impl.cc	View		2 chunks	+6 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

sadrul

Hi! Not sure if this is what you had in mind. But this seems to ...

5 years, 7 months ago (2015-05-15 13:36:41 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134003004/1

5 years, 7 months ago (2015-05-15 17:50:33 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-15 17:57:56 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/246205e6541383ed6bc431e5f1fdcde8db9e2811
Cr-Commit-Position: refs/heads/master@{#330130}