Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1134003003: Revert "Resolve references to "this" the same way as normal variables" (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Hablich
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "Resolve references to "this" the same way as normal variables" ... and the following two "PPC: Resolve references to "this" the same way as normal variables" "Remove Scope::scope_uses_this_ flag" R=hablich@chromium.org BUG=chromium:487289 LOG=N Committed: https://crrev.com/e24b31f0033f3c9664986f81562622d34b6b0c18 Cr-Commit-Position: refs/heads/master@{#28395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -354 lines) Patch
M src/arm/full-codegen-arm.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +14 lines, -45 lines 0 comments Download
M src/contexts.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M src/heap/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/parser.cc View 6 chunks +9 lines, -14 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M src/preparser.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +8 lines, -13 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 3 chunks +3 lines, -17 lines 0 comments Download
M src/scopeinfo.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/scopes.h View 7 chunks +13 lines, -20 lines 0 comments Download
M src/scopes.cc View 11 chunks +38 lines, -42 lines 0 comments Download
M src/variables.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-parsing.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/debug-scopes.js View 1 chunk +0 lines, -4 lines 0 comments Download
D test/mjsunit/harmony/arrow-functions-this.js View 1 chunk +0 lines, -81 lines 0 comments Download
M test/mjsunit/testcfg.py View 2 chunks +1 line, -2 lines 0 comments Download
D test/mjsunit/this-dynamic-lookup.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 7 months ago (2015-05-13 12:42:24 UTC) #1
Michael Hablich
On 2015/05/13 12:42:24, Yang wrote: lgtm
5 years, 7 months ago (2015-05-13 12:42:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134003003/1
5 years, 7 months ago (2015-05-13 12:45:10 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 13:30:16 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 13:30:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e24b31f0033f3c9664986f81562622d34b6b0c18
Cr-Commit-Position: refs/heads/master@{#28395}

Powered by Google App Engine
This is Rietveld 408576698