Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11340029: Move remaining files in content\browser to the content namespace. (Closed)

Created:
8 years, 1 month ago by jam
Modified:
8 years, 1 month ago
Reviewers:
tfarina
CC:
chromium-reviews, MAD, creis+watch_chromium.org, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, rdsmith+dwatch_chromium.org, ajwong+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Move remaining files in content\browser to the content namespace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164828

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -261 lines) Patch
M content/browser/browser_main.h View 1 chunk +2 lines, -2 lines 2 comments Download
M content/browser/browser_main.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/browser_main_loop.h View 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/browser_main_runner.cc View 6 chunks +8 lines, -16 lines 0 comments Download
M content/browser/browser_url_handler_impl.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/browser_url_handler_impl.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M content/browser/browser_url_handler_impl_unittest.cc View 5 chunks +8 lines, -4 lines 0 comments Download
M content/browser/browsing_instance.h View 5 chunks +11 lines, -10 lines 0 comments Download
M content/browser/browsing_instance.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/cert_store_impl.h View 4 chunks +10 lines, -6 lines 0 comments Download
M content/browser/cert_store_impl.cc View 4 chunks +17 lines, -14 lines 1 comment Download
M content/browser/child_process_security_policy_browsertest.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M content/browser/child_process_security_policy_impl.h View 2 chunks +5 lines, -1 line 1 comment Download
M content/browser/child_process_security_policy_impl.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M content/browser/child_process_security_policy_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M content/browser/cross_site_request_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/cross_site_request_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/database_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/device_monitor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/base_file_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/download_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/encrypted_media_browsertest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/histogram_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/histogram_internals_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/histogram_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/histogram_synchronizer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/histogram_synchronizer.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/host_zoom_map_impl.h View 3 chunks +11 lines, -8 lines 0 comments Download
M content/browser/host_zoom_map_impl.cc View 6 chunks +19 lines, -24 lines 3 comments Download
M content/browser/host_zoom_map_impl_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/mach_broker_mac.h View 5 chunks +9 lines, -5 lines 0 comments Download
M content/browser/mach_broker_mac.cc View 3 chunks +21 lines, -21 lines 0 comments Download
M content/browser/mach_broker_mac_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/mime_registry_message_filter.h View 2 chunks +6 lines, -2 lines 1 comment Download
M content/browser/mime_registry_message_filter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/plugin_data_remover_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_save_blocker_mac.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/power_save_blocker_win.cc View 4 chunks +3 lines, -4 lines 1 comment Download
M content/browser/profiler_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/profiler_controller_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/profiler_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/safe_util_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/safe_util_win.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/browser/site_instance_impl.h View 5 chunks +17 lines, -17 lines 0 comments Download
M content/browser/site_instance_impl.cc View 6 chunks +13 lines, -16 lines 1 comment Download
M content/browser/storage_partition_impl_map.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/system_message_window_win.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/system_message_window_win.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/system_message_window_win_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/trace_controller_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/trace_controller_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/trace_message_filter.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/trace_message_filter.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/trace_subscriber_stdio.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/trace_subscriber_stdio_unittest.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/user_metrics.cc View 3 chunks +5 lines, -9 lines 1 comment Download
M content/public/browser/site_instance.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
jam
8 years, 1 month ago (2012-10-30 01:03:16 UTC) #1
tfarina
I'll review this tomorrow morning. I'm going to sleep. Just TBR me is fine.
8 years, 1 month ago (2012-10-30 01:05:35 UTC) #2
tfarina
lgtm https://codereview.chromium.org/11340029/diff/1/content/browser/browser_main.h File content/browser/browser_main.h (right): https://codereview.chromium.org/11340029/diff/1/content/browser/browser_main.h#newcode8 content/browser/browser_main.h:8: #include "base/basictypes.h" nit: remove, unused. https://codereview.chromium.org/11340029/diff/1/content/browser/browser_main.h#newcode17 content/browser/browser_main.h:17: CONTENT_EXPORT ...
8 years, 1 month ago (2012-10-30 21:59:49 UTC) #3
tfarina
8 years, 1 month ago (2012-10-30 22:19:06 UTC) #4 
https://codereview.chromium.org/11340029/diff/1/content/browser/host_zoom_map...
File content/browser/host_zoom_map_impl.cc (right):

https://codereview.chromium.org/11340029/diff/1/content/browser/host_zoom_map...
content/browser/host_zoom_map_impl.cc:44: this,
NOTIFICATION_RENDER_VIEW_HOST_WILL_CLOSE_RENDER_VIEW,
this fits above now.

https://codereview.chromium.org/11340029/diff/1/content/browser/host_zoom_map...
content/browser/host_zoom_map_impl.cc:93: NOTIFICATION_ZOOM_LEVEL_CHANGED,
fits above;

https://codereview.chromium.org/11340029/diff/1/content/browser/host_zoom_map...
content/browser/host_zoom_map_impl.cc:149: NOTIFICATION_ZOOM_LEVEL_CHANGED,
fits above.

https://codereview.chromium.org/11340029/diff/1/content/browser/mime_registry...
File content/browser/mime_registry_message_filter.h (right):

https://codereview.chromium.org/11340029/diff/1/content/browser/mime_registry...
content/browser/mime_registry_message_filter.h:18: const IPC::Message& message,
fits above iirc.

https://codereview.chromium.org/11340029/diff/1/content/browser/power_save_bl...
File content/browser/power_save_blocker_win.cc (right):

https://codereview.chromium.org/11340029/diff/1/content/browser/power_save_bl...
content/browser/power_save_blocker_win.cc:84: int delta) {
probably fits above now.

https://codereview.chromium.org/11340029/diff/1/content/browser/site_instance...
File content/browser/site_instance_impl.cc (right):

https://codereview.chromium.org/11340029/diff/1/content/browser/site_instance...
content/browser/site_instance_impl.cc:314: DCHECK(type ==
NOTIFICATION_RENDERER_PROCESS_TERMINATED);
DCHECK_EQ

Powered by Google App Engine
This is Rietveld 408576698