Issue 11340019: Place <webview> tag behind a flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11340019: Place <webview> tag behind a flag. (Closed)

Created:
8 years, 1 month ago by Fady Samuel

Modified:
8 years, 1 month ago

Reviewers:
Charlie Reis, sky

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Place <webview> tag behind a flag. --enable-webview is a chrome switch. It enables the <webview> tag and Browser Plugin in Apps. --enable-browser-plugin-for-all-view-types is a content switch. It enables the browser plugin everywhere: Apps, normal web content, content_shell, etc. It also enables <webview> in Apps. BUG=158384 Test=manually using <webview> in App, <object type="application/browser-plugin"></object> in web_content Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164842

Patch Set 1 #

Patch Set 2 : Fixed WebViewTest.* #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -2 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/web_view_browsertest.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/dispatcher.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/11340019/5001

8 years, 1 month ago (2012-10-29 23:30:19 UTC) #5

Change committed as 164842

Expand Messages | Collapse Messages