url/gurl.h - Issue 1133943002: Create net::FormatOriginForDisplay helper function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: url/gurl.h

Issue 1133943002: Create net::FormatOriginForDisplay helper function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes, tests, and put the big TODO in the right place. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: url/gurl.h

diff --git a/url/gurl.h b/url/gurl.h

index b9136b81f6a8b962a79d3e0435addc614a1e6bb0..067b0b39486c1b45828e9be2d467e6f9cb84317a 100644

--- a/url/gurl.h

+++ b/url/gurl.h

@@ -198,6 +198,10 @@ class URL_EXPORT GURL {

// scheme. Standard schemes have an authority and a path section. This

// includes file: and filesystem:, which some callers may want to filter out

// explicitly by calling SchemeIsFile[System].

+ //

+ // TODO(palmer): Determine whether GURL::IsStandard should return false for

+ // filesystem: URLs.

+ // https://code.google.com/p/chromium/issues/detail?id=487399

bool IsStandard() const;

// Returns true if the given parameter (should be lower-case ASCII to match

« net/base/net_util_icu.cc ('K') | « net/base/net_util_icu_unittest.cc ('k') | no next file » | no next file with comments »