Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133933004: add Min to SkNi, specialized for u8 and u16 on SSE and NEON (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add Min to SkNi, specialized for u8 and u16 on SSE and NEON 0x8001 / 0x7fff don't seem to work, but we were close: 0x8000 does. I plan to use this to implement the Difference xfermode, and it seems generally handy. BUG=skia: Committed: https://skia.googlesource.com/skia/+/27e517ae533775889c98c65fa2f07b98357ecbc2

Patch Set 1 #

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M src/core/SkNx.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/opts/SkNx_neon.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/opts/SkNx_sse.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M tests/SkNxTest.cpp View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
mtklein
5 years, 7 months ago (2015-05-14 21:23:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133933004/1
5 years, 7 months ago (2015-05-14 21:23:56 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/326)
5 years, 7 months ago (2015-05-14 21:28:30 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133933004/20001
5 years, 7 months ago (2015-05-14 21:37:35 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-14 21:45:45 UTC) #10
caryclark
lgtm
5 years, 7 months ago (2015-05-14 22:13:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133933004/20001
5 years, 7 months ago (2015-05-15 00:52:51 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:53:11 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/27e517ae533775889c98c65fa2f07b98357ecbc2

Powered by Google App Engine
This is Rietveld 408576698