Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2483)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.h

Issue 113391: Refactor the inner classes from SSLManager to their own files to reduce the c... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/ssl_blocking_page.h
===================================================================
--- chrome/browser/ssl/ssl_blocking_page.h (revision 16018)
+++ chrome/browser/ssl/ssl_blocking_page.h (working copy)
@@ -7,10 +7,11 @@
#include <string>
-#include "chrome/browser/ssl/ssl_manager.h"
+#include "chrome/browser/ssl/ssl_error_info.h"
#include "chrome/browser/tab_contents/interstitial_page.h"
class DictionaryValue;
+class SSLCertErrorHandler;
// This class is responsible for showing/hiding the interstitial page that is
// shown when a certificate error happens.
@@ -23,16 +24,16 @@
public:
// Should return the information about the error that causes this blocking
// page.
- virtual SSLErrorInfo GetSSLErrorInfo(SSLManager::CertError* error) = 0;
+ virtual SSLErrorInfo GetSSLErrorInfo(SSLCertErrorHandler* handler) = 0;
// Notification that the user chose to reject the certificate.
- virtual void OnDenyCertificate(SSLManager::CertError* error) = 0;
+ virtual void OnDenyCertificate(SSLCertErrorHandler* handler) = 0;
// Notification that the user chose to accept the certificate.
- virtual void OnAllowCertificate(SSLManager::CertError* error) = 0;
+ virtual void OnAllowCertificate(SSLCertErrorHandler* handler) = 0;
};
- SSLBlockingPage(SSLManager::CertError* error, Delegate* delegate);
+ SSLBlockingPage(SSLCertErrorHandler* handler, Delegate* delegate);
virtual ~SSLBlockingPage();
// A method that sets strings in the specified dictionary from the passed
@@ -56,7 +57,7 @@
// The error we represent. We will either call CancelRequest() or
// ContinueRequest() on this object.
- scoped_refptr<SSLManager::CertError> error_;
+ scoped_refptr<SSLCertErrorHandler> handler_;
// Our delegate. It provides useful information, like the title and details
// about this error.

Powered by Google App Engine
This is Rietveld 408576698