Issue 113391: Refactor the inner classes from SSLManager to their own files to reduce the c...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113391: Refactor the inner classes from SSLManager to their own files to reduce the c... (Closed)

Created:
11 years, 7 months ago by abarth-chromium

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Refactor the inner classes from SSLManager to their own files to reduce the complexity of SSLManager. Heading towards unit testability of this code. TBR=jcampan TEST=No functionality change. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16041

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3362 lines, -3273 lines)			Patch
M	chrome/browser/browser.vcproj	View	1 chunk	+2700 lines, -2680 lines	0 comments	Download
M	chrome/browser/ssl/ssl_blocking_page.h	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ssl/ssl_blocking_page.cc	View	5 chunks	+8 lines, -7 lines	0 comments	Download
A	chrome/browser/ssl/ssl_cert_error_handler.h	View	1 chunk	+58 lines, -0 lines	1 comment	Download
A	chrome/browser/ssl/ssl_error_handler.h	View	1 chunk	+176 lines, -0 lines	0 comments	Download
A	chrome/browser/ssl/ssl_error_handler.cc	View	1 chunk	+209 lines, -0 lines	0 comments	Download
M	chrome/browser/ssl/ssl_manager.h	View	4 chunks	+9 lines, -272 lines	0 comments	Download
M	chrome/browser/ssl/ssl_manager.cc	View	7 chunks	+28 lines, -250 lines	0 comments	Download
A	chrome/browser/ssl/ssl_mixed_content_handler.h	View	1 chunk	+38 lines, -0 lines	1 comment	Download
M	chrome/browser/ssl/ssl_policy.h	View	3 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/ssl/ssl_policy.cc	View	12 chunks	+51 lines, -50 lines	0 comments	Download
A	chrome/browser/ssl/ssl_request_info.h	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

I'm going to try to land this so I don't have it sitting in my ...

11 years, 7 months ago (2009-05-14 05:44:10 UTC) #1

jcampan

11 years, 7 months ago (2009-05-14 17:02:40 UTC) #2

LGTM

Note that there are some lint errors.

http://codereview.chromium.org/113391/diff/1/11
File chrome/browser/ssl/ssl_cert_error_handler.h (right):

http://codereview.chromium.org/113391/diff/1/11#newcode19
Line 19: // We mark this method as private because it is tricky to correctly
It is not private anymore, fix comment?

http://codereview.chromium.org/113391/diff/1/9
File chrome/browser/ssl/ssl_mixed_content_handler.h (right):

http://codereview.chromium.org/113391/diff/1/9#newcode38
Line 38: #endif  // CHROME_BROWSER_SSL_SSL_MIXED_CONTENT_HANDLERR_H_
Typo in comment _HANDLERR_H_ -> HANDLER_H_

Expand Messages | Collapse Messages