Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3145)

Unified Diff: chrome/browser/google/google_url_tracker_map_entry.cc

Issue 11339060: Fix a crash that could occur if the user closed a tab with an uncommitted search navigation that we… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/google/google_url_tracker.cc ('k') | chrome/browser/google/google_url_tracker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/google/google_url_tracker_map_entry.cc
===================================================================
--- chrome/browser/google/google_url_tracker_map_entry.cc (revision 164818)
+++ chrome/browser/google/google_url_tracker_map_entry.cc (working copy)
@@ -47,9 +47,12 @@
}
void GoogleURLTrackerMapEntry::Close(bool redo_search) {
- if (infobar_)
+ if (infobar_) {
infobar_->Close(redo_search);
- else
+ } else {
+ // WARNING: |infobar_helper_| may point to a deleted object. Do not
+ // dereference it! See GoogleURLTracker::OnTabClosed().
google_url_tracker_->DeleteMapEntryForHelper(infobar_helper_);
+ }
// WARNING: At this point |this| has been deleted!
}
« no previous file with comments | « chrome/browser/google/google_url_tracker.cc ('k') | chrome/browser/google/google_url_tracker_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698