Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: lib/compiler/implementation/js_backend/emitter.dart

Issue 11339042: Revert "Change signature of noSuchMethod to take an InvocationMirror." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/enqueue.dart ('k') | lib/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/js_backend/emitter.dart
diff --git a/lib/compiler/implementation/js_backend/emitter.dart b/lib/compiler/implementation/js_backend/emitter.dart
index 13be72b350b48e274b38ef0730db674760652abe..b9d30a3fa4b426e1d5f166bf42e43bd1bf763679 100644
--- a/lib/compiler/implementation/js_backend/emitter.dart
+++ b/lib/compiler/implementation/js_backend/emitter.dart
@@ -1254,8 +1254,8 @@ $classesCollector.$mangledName = {'':
// Do not generate no such method handlers if there is no class.
if (compiler.codegenWorld.instantiatedClasses.isEmpty) return;
- String noSuchMethodName = namer.publicInstanceMethodNameByArity(
- Compiler.NO_SUCH_METHOD, Compiler.NO_SUCH_METHOD_ARG_COUNT);
+ String noSuchMethodName =
+ namer.publicInstanceMethodNameByArity(Compiler.NO_SUCH_METHOD, 2);
// Keep track of the JavaScript names we've already added so we
// do not introduce duplicates (bad for code size).
@@ -1280,36 +1280,14 @@ $classesCollector.$mangledName = {'':
}
CodeBuffer generateMethod(String methodName, Selector selector) {
- // Values match JSInvocationMirror in js-helper library.
- const int METHOD = 0;
- const int GETTER = 1;
- const int SETTER = 2;
- int type = METHOD;
- if (selector.isGetter()) {
- type = GETTER;
- } else if (selector.isSetter()) {
- type = SETTER;
- }
CodeBuffer args = new CodeBuffer();
for (int i = 0; i < selector.argumentCount; i++) {
if (i != 0) args.add(', ');
args.add('\$$i');
}
- CodeBuffer argNames = new CodeBuffer();
- List<SourceString> names = selector.getOrderedNamedArguments();
- for (int i = 0; i < names.length; i++) {
- if (i != 0) argNames.add(', ');
- argNames.add('"');
- argNames.add(names[i].slowToString());
- argNames.add('"');
- }
- String internalName = namer.instanceMethodInvocationName(
- selector.library, new SourceString(methodName), selector);
CodeBuffer buffer = new CodeBuffer();
buffer.add('function($args) {\n');
- buffer.add(' return this.$noSuchMethodName('
- '\$.createInvocationMirror("$methodName", "$internalName",'
- ' $type, [$args], [$argNames]));\n');
+ buffer.add(' return this.$noSuchMethodName("$methodName", [$args]);\n');
buffer.add(' }');
return buffer;
}
« no previous file with comments | « lib/compiler/implementation/enqueue.dart ('k') | lib/compiler/implementation/lib/core_patch.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698