Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133903004: <webview> documentation: addContentScripts/removeContentScripts should be in alphabetical order. (Closed)

Created:
5 years, 7 months ago by Xi Han
Modified:
5 years, 7 months ago
Reviewers:
Fady Samuel, lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

<webview> documentation: addContentScripts/removeContentScripts should be in alphabetical order. BUG=486291 Committed: https://crrev.com/de37c68a5138e78484013990d091b43f96c7b2a0 Cr-Commit-Position: refs/heads/master@{#329157}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -39 lines) Patch
M chrome/common/extensions/api/webview_tag.json View 1 3 chunks +34 lines, -35 lines 0 comments Download
M extensions/common/api/web_view_internal.json View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Xi Han
Please take a look, thanks.
5 years, 7 months ago (2015-05-11 13:38:55 UTC) #2
Xi Han
Istiaque: Please take a look, thanks!
5 years, 7 months ago (2015-05-11 14:33:35 UTC) #7
lazyboy
https://chromiumcodereview.appspot.com/1133903004/diff/1/chrome/common/extensions/api/webview_tag.json File chrome/common/extensions/api/webview_tag.json (right): https://chromiumcodereview.appspot.com/1133903004/diff/1/chrome/common/extensions/api/webview_tag.json#newcode689 chrome/common/extensions/api/webview_tag.json:689: "minimum": 1 See comment below. https://chromiumcodereview.appspot.com/1133903004/diff/1/chrome/common/extensions/api/webview_tag.json#newcode952 chrome/common/extensions/api/webview_tag.json:952: "minimum": 0, ...
5 years, 7 months ago (2015-05-11 14:40:59 UTC) #8
Xi Han
PTAL, thanks:) https://chromiumcodereview.appspot.com/1133903004/diff/1/chrome/common/extensions/api/webview_tag.json File chrome/common/extensions/api/webview_tag.json (right): https://chromiumcodereview.appspot.com/1133903004/diff/1/chrome/common/extensions/api/webview_tag.json#newcode689 chrome/common/extensions/api/webview_tag.json:689: "minimum": 1 On 2015/05/11 14:40:59, lazyboy wrote: ...
5 years, 7 months ago (2015-05-11 15:10:58 UTC) #9
lazyboy
lgtm
5 years, 7 months ago (2015-05-11 15:28:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133903004/20001
5 years, 7 months ago (2015-05-11 15:29:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 16:38:19 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 16:40:08 UTC) #14
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/de37c68a5138e78484013990d091b43f96c7b2a0
Cr-Commit-Position: refs/heads/master@{#329157}

Powered by Google App Engine
This is Rietveld 408576698