Move content\browser\renderer_host\media to content namespace.

Move content\browser\renderer_host\media to content namespace.

TBR=tfarina
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164670

[jam, 2012-10-29 17:15:07]

(please only review this change and not nits to existing code, thanks)

[tfarina, 2012-10-29 17:41:34]

lgtm

Just a few nits below, hopefully they were to the point.

Of course, please, just ignore them.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_dispatcher_host.h (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_dispatcher_host.h:24: : public
BrowserMessageFilter,
nit: it does fits into the previous line.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_manager.h (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_manager.h:51: class
MediaStreamUIController;
nit: sort

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_ui_controller.cc (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_ui_controller.cc:72: int
render_pid,
nit: it does fits into the previous line now.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_ui_controller.cc:126:
SettingsRequester* requester)
fits above.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/video_capture_manager_unittest.cc
(right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/video_capture_manager_unittest.cc:56: };  //
class MockMediaStreamProviderListener
so weird this comment :/

sorry for point out :(

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/web_contents_video_capture_device.h
(right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/web_contents_video_capture_device.h:64:
RenderWidgetHost* test_source);
fits above now.

https://codereview.chromium.org/11339014/diff/1/content/common/media/video_ca...
File content/common/media/video_capture.h (right):

https://codereview.chromium.org/11339014/diff/1/content/common/media/video_ca...
content/common/media/video_capture.h:17: VIDEO_CAPTURE_STATE_STARTING,
nice!

https://codereview.chromium.org/11339014/diff/1/content/renderer/media/video_...
File content/renderer/media/video_capture_message_filter_unittest.cc (right):

https://codereview.chromium.org/11339014/diff/1/content/renderer/media/video_...
content/renderer/media/video_capture_message_filter_unittest.cc:77:
VideoCaptureState state() { return state_; }
sorry for point this out too, but all these getter accessors should be const, of
course this is out of the scoped of this change. :(

[jam, 2012-10-29 18:14:45]

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_dispatcher_host.h (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_dispatcher_host.h:24: : public
BrowserMessageFilter,
On 2012/10/29 17:41:34, tfarina wrote:
> nit: it does fits into the previous line.

Done.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_manager.h (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_manager.h:51: class
MediaStreamUIController;
On 2012/10/29 17:41:34, tfarina wrote:
> nit: sort

Done.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_ui_controller.cc (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_ui_controller.cc:72: int
render_pid,
On 2012/10/29 17:41:34, tfarina wrote:
> nit: it does fits into the previous line now.

i'm not sure what you mean? the 4 won't fit in the same line. i'm hesitant to
change the style of this function from one arg per line to multiple, since it
seems that the author preferred this

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_ui_controller.cc:126:
SettingsRequester* requester)
On 2012/10/29 17:41:34, tfarina wrote:
> fits above.

Done.

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/web_contents_video_capture_device.h
(right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/web_contents_video_capture_device.h:64:
RenderWidgetHost* test_source);
On 2012/10/29 17:41:34, tfarina wrote:
> fits above now.

Done.

[tfarina, 2012-10-29 18:19:33]

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_ui_controller.cc (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_ui_controller.cc:72: int
render_pid,
On 2012/10/29 18:14:45, John Abd-El-Malek wrote:
> On 2012/10/29 17:41:34, tfarina wrote:
> > nit: it does fits into the previous line now.
> 
> i'm not sure what you mean? the 4 won't fit in the same line. i'm hesitant to
> change the style of this function from one arg per line to multiple, since it
> seems that the author preferred this

I mean this:
 MediaStreamRequestForUI(int render_pid,
                         int render_vid,
                         ...) {
                         ^ align here 
 }

[jam, 2012-10-29 18:25:03]

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/media/media_stream_ui_controller.cc (right):

https://codereview.chromium.org/11339014/diff/1/content/browser/renderer_host...
content/browser/renderer_host/media/media_stream_ui_controller.cc:72: int
render_pid,
On 2012/10/29 18:19:33, tfarina wrote:
> On 2012/10/29 18:14:45, John Abd-El-Malek wrote:
> > On 2012/10/29 17:41:34, tfarina wrote:
> > > nit: it does fits into the previous line now.
> > 
> > i'm not sure what you mean? the 4 won't fit in the same line. i'm hesitant
to
> > change the style of this function from one arg per line to multiple, since
it
> > seems that the author preferred this
> 
> I mean this:
>  MediaStreamRequestForUI(int render_pid,
>                          int render_vid,
>                          ...) {
>                          ^ align here 
>  }

Done.