Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/cronet/android/cronet_url_request_context_adapter.cc

Issue 1133883002: [Cronet] Enable persistence mode for Sdch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@quic_server_remove_loop
Patch Set: Address Misha's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_url_request_context_adapter.cc
diff --git a/components/cronet/android/cronet_url_request_context_adapter.cc b/components/cronet/android/cronet_url_request_context_adapter.cc
index 2f736a9dc1c3161d501ad938a1c01dbe468e7cf1..7cab0d9e281c190994deaa35c41974a1acb13c9f 100644
--- a/components/cronet/android/cronet_url_request_context_adapter.cc
+++ b/components/cronet/android/cronet_url_request_context_adapter.cc
@@ -11,6 +11,7 @@
#include "base/files/scoped_file.h"
#include "base/logging.h"
#include "base/memory/scoped_vector.h"
+#include "base/prefs/pref_filter.h"
#include "base/single_thread_task_runner.h"
#include "base/values.h"
#include "components/cronet/url_request_context_config.h"
@@ -185,6 +186,18 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
context_builder.set_net_log(net_log.release());
context_builder.set_proxy_config_service(proxy_config_service_.release());
config->ConfigureURLRequestContextBuilder(&context_builder);
+
+ // Set up pref file if storage path is specified.
+ // TODO(xunjieli): maybe get rid of the condition on sdch.
+ if (!config->storage_path.empty() && config->enable_sdch) {
+ base::FilePath filepath(config->storage_path);
+ filepath = filepath.Append(FILE_PATH_LITERAL("local_prefs.json"));
+ json_pref_store_ = new JsonPrefStore(
+ filepath, GetFileThread()->task_runner(), scoped_ptr<PrefFilter>());
+ json_pref_store_->ReadPrefsAsync(nullptr);
+ context_builder.SetFileTaskRunner(GetFileThread()->task_runner());
+ }
+
context_.reset(context_builder.Build());
default_load_flags_ = net::LOAD_DO_NOT_SAVE_COOKIES |
@@ -196,6 +209,8 @@ void CronetURLRequestContextAdapter::InitializeOnNetworkThread(
DCHECK(context_->sdch_manager());
sdch_owner_.reset(
new net::SdchOwner(context_->sdch_manager(), context_.get()));
+ if (json_pref_store_)
+ sdch_owner_->EnablePersistentStorage(json_pref_store_.get());
}
// Currently (circa M39) enabling QUIC requires setting probability threshold.
@@ -352,6 +367,15 @@ void CronetURLRequestContextAdapter::StopNetLogOnNetworkThread() {
}
}
+base::Thread* CronetURLRequestContextAdapter::GetFileThread() {
+ DCHECK(GetNetworkTaskRunner()->BelongsToCurrentThread());
+ if (!file_thread_) {
+ file_thread_.reset(new base::Thread("Network File Thread"));
+ file_thread_->Start();
+ }
+ return file_thread_.get();
+}
+
// Creates RequestContextAdater if config is valid URLRequestContextConfig,
// returns 0 otherwise.
static jlong CreateRequestContextAdapter(JNIEnv* env,

Powered by Google App Engine
This is Rietveld 408576698