Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1133873002: Centre message windows when they are shown. (Closed)

Created:
5 years, 7 months ago by Jamie
Modified:
5 years, 7 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Centre message windows when they are shown. This adds a missing optional parameter to resizeWindowToContent. The parameter is already specified when the message is updated--not including it here too was an oversight. Committed: https://crrev.com/9a2648963341a87deb70d2e4d5eae13884b3ef75 Cr-Commit-Position: refs/heads/master@{#329202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/webapp/base/js/message_window.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
ptal
5 years, 7 months ago (2015-05-08 20:41:12 UTC) #2
kelvinp
lgtm
5 years, 7 months ago (2015-05-11 17:13:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133873002/1
5 years, 7 months ago (2015-05-11 17:33:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 18:43:12 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:45:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a2648963341a87deb70d2e4d5eae13884b3ef75
Cr-Commit-Position: refs/heads/master@{#329202}

Powered by Google App Engine
This is Rietveld 408576698