content/browser/service_worker/service_worker_version.h - Issue 1133853007: Add UMA to record the ratio of how many fetch events are not handled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 1133853007: Add UMA to record the ratio of how many fetch events are not handled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_metrics.cc ('k') | content/browser/service_worker/service_worker_version.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index b020c25214b35b2b508811919be09e4d2cb0cde8..af011e563665c7204a35ff22f653eb996a6407c3 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -329,6 +329,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

FRIEND_TEST_ALL_PREFIXES(ServiceWorkerVersionBrowserTest,

TimeoutWorkerInEvent);

+ class ServiceWorkerEventMetrics;

typedef ServiceWorkerVersion self;

using ServiceWorkerClients = std::vector<ServiceWorkerClientInfo>;

@@ -553,6 +555,8 @@ class CONTENT_EXPORT ServiceWorkerVersion

// running |start_callbacks_|.

ServiceWorkerStatusCode start_worker_status_ = SERVICE_WORKER_OK;

+ scoped_ptr<ServiceWorkerEventMetrics> metrics_;

base::WeakPtrFactory<ServiceWorkerVersion> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(ServiceWorkerVersion);