Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: content/browser/service_worker/service_worker_metrics.h

Issue 1133853007: Add UMA to record the ratio of how many fetch events are not handled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.h
diff --git a/content/browser/service_worker/service_worker_metrics.h b/content/browser/service_worker/service_worker_metrics.h
index 7b477af24f23930db2ea0c25159bcc0fbc462ae6..d77fd2bd38515fb4a38686ce115e3b433a3c7266 100644
--- a/content/browser/service_worker/service_worker_metrics.h
+++ b/content/browser/service_worker/service_worker_metrics.h
@@ -65,6 +65,11 @@ class ServiceWorkerMetrics {
static void RecordActivateEventStatus(ServiceWorkerStatusCode status);
static void RecordInstallEventStatus(ServiceWorkerStatusCode status);
+ // Records the ratio of unhandled events to the all events fired during
+ // the lifetime of ServiceWorker.
+ static void RecordEventStatus(unsigned int fired_events,
Alexei Svitkine (slow) 2015/05/14 17:49:59 Nit: Chromium style doesn't usually use unsigned i
kinuko 2015/05/15 00:05:37 Chromium guide says following sentence, is that wh
+ unsigned int handled_events);
+
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(ServiceWorkerMetrics);
};

Powered by Google App Engine
This is Rietveld 408576698