Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: content/browser/service_worker/service_worker_metrics.cc

Issue 1133853007: Add UMA to record the ratio of how many fetch events are not handled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_metrics.cc
diff --git a/content/browser/service_worker/service_worker_metrics.cc b/content/browser/service_worker/service_worker_metrics.cc
index dc3c157ab2cc9310699590c828902b3d442c97b4..8c34015d4931155f6df16c7f3db6851f73ab960d 100644
--- a/content/browser/service_worker/service_worker_metrics.cc
+++ b/content/browser/service_worker/service_worker_metrics.cc
@@ -107,4 +107,12 @@ void ServiceWorkerMetrics::RecordInstallEventStatus(
SERVICE_WORKER_ERROR_MAX_VALUE);
}
+void ServiceWorkerMetrics::RecordEventStatus(unsigned int fired_events,
+ unsigned int handled_events) {
+ int unhandled_ratio = static_cast<double>(fired_events - handled_events) *
+ 100.0 / static_cast<double>(fired_events);
Alexei Svitkine (slow) 2015/05/14 17:49:59 Nit: I don't think you actually need the double ca
kinuko 2015/05/15 00:05:37 Done.
+ UMA_HISTOGRAM_PERCENTAGE("ServiceWorker.UnhandledEventRatio",
+ unhandled_ratio);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698