Source/core/dom/FirstLetterPseudoElement.cpp - Issue 1133853006: Elements whose contents start with an astral Unicode symbol disappear when CSS `::first-letter` is …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/FirstLetterPseudoElement.cpp

Issue 1133853006: Elements whose contents start with an astral Unicode symbol disappear when CSS `::first-letter` is … Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/FirstLetterPseudoElement.cpp

diff --git a/Source/core/dom/FirstLetterPseudoElement.cpp b/Source/core/dom/FirstLetterPseudoElement.cpp

index d47a521eba3c9acb4c8cc2dc9c3489c14df10b4c..3fc0c394093667a0ac2f3bf4e8a652089250522c 100644

--- a/Source/core/dom/FirstLetterPseudoElement.cpp

+++ b/Source/core/dom/FirstLetterPseudoElement.cpp

@@ -30,6 +30,7 @@

#include "core/layout/LayoutObjectInlines.h"

#include "core/layout/LayoutText.h"

#include "core/layout/LayoutTextFragment.h"

+#include "platform/text/TextBreakIterator.h"

#include "wtf/TemporaryChange.h"

#include "wtf/text/WTFString.h"

#include "wtf/unicode/icu/UnicodeIcu.h"

@@ -77,7 +78,7 @@ unsigned FirstLetterPseudoElement::firstLetterLength(const String& text)

return 0;

// Account the next character for first letter.

- length++;

+ length += numCharactersInGraphemeClusters(text.substring(length), 1);

// Keep looking for allowed punctuation for the :first-letter.

for (; length < textLength; ++length) {

« no previous file with comments | « no previous file | Source/platform/text/TextBreakIterator.h » ('j') | Source/platform/text/TextBreakIterator.cpp » ('J')