Media Router: Replace sink custom elements with core/paper elements.

Media Router: Replace sink custom elements with core/paper elements.

- Removes media-router-sink custom element.
- Removes media-router-sink-picker custom element.
- Replaces media-router-sink with paper-item (material).
- Replaces media-router-sink-picker with core-menu.
- Removes sink type icons.

Committed: https://crrev.com/0d4b2884a58526ee74fb9b060488cd6fc31c50f3
Cr-Commit-Position: refs/heads/master@{#329312}

[apacible, 2015-05-08 22:02:01]

Patchset #1 (id:1) has been deleted

[apacible, 2015-05-08 22:05:23]

Patchset #1 (id:20001) has been deleted

[apacible, 2015-05-08 22:29:32]

Patchset #1 (id:40001) has been deleted

[apacible, 2015-05-08 23:05:20]

Patchset #1 (id:60001) has been deleted

[apacible, 2015-05-08 23:06:51]

Patchset #1 (id:80001) has been deleted

[apacible, 2015-05-08 23:07:11]

apacible@chromium.org changed reviewers:
+ jhawkins@chromium.org, jlklein@chromium.org, mfoltz@chromium.org,
michaelpg@chromium.org

[apacible, 2015-05-08 23:19:27]

PTAL, thanks!

I ran any aesthetic behavior changes past our UX designer, such as the ripple
effect when a sink is clicked.

Screenshots:
Sinks:
LTR: https://screenshot.googleplex.com/E3TMiFTUVOd
RTL: https://screenshot.googleplex.com/ZyQgZWMDVXw

Sink w/route:
LTR: https://screenshot.googleplex.com/uGJqnQsT2ie
RTL: https://screenshot.googleplex.com/LyRZatLGTrN.png

Sink mouseover:
LTR: https://screenshot.googleplex.com/d7NFE9Ohqdb
RTL: https://screenshot.googleplex.com/sSqKoN3HwpT

Sink last clicked:
LTR: https://screenshot.googleplex.com/Lf13Kmyo4oC
RTL: https://screenshot.googleplex.com/bzZ7EZY7tNe

Show cast modes:
LTR: https://screenshot.googleplex.com/TdPBcbx0fLK
RTL: https://screenshot.googleplex.com/mrGBpPbXokt

z-index added to fix:
On show cast modes: https://screenshot.googleplex.com/QdKTRbyjy8E.png
On hover over sink: https://screenshot.googleplex.com/JgOMRCO9n9t.png

[mark a. foltz, 2015-05-09 06:37:38]

Nice!  Much simpler!

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
File chrome/browser/media_router_resources.grdp (left):

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
chrome/browser/media_router_resources.grdp:34: <include
name="IDR_MEDIA_ROUTER_CHROMECAST_ICON"
file="resources\media_router\elements\icon\chromecast-icon.png" type="BINDATA"
/>
Does hardware.html have all the icons we need?

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
chrome/browser/media_router_resources.grdp:35: <include
name="IDR_MEDIA_ROUTER_CHROMECAST_2X_ICON"
file="resources\media_router\elements\icon\chromecast-icon2x.png" type="BINDATA"
/>
Can you add a patch to chrome/browser/OWNERS to add the committers on the team
as OWNERS of this file?

Alternatively could this file be moved to resources/media_router and a new
OWNERS added there?

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:50:
<template bind="{{routeMap_[sinkToRouteMap_[sink.id]] as route}}">
The extra lookup to get the route from the sink makes this template a bit
complex.

Another approach would it be to produce a list of [sink, route?] pairs in
media_router_container.js so that the template can simply iterate over one list.

WDYT?

[apacible, 2015-05-11 17:59:48]

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
File chrome/browser/media_router_resources.grdp (left):

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
chrome/browser/media_router_resources.grdp:34: <include
name="IDR_MEDIA_ROUTER_CHROMECAST_ICON"
file="resources\media_router\elements\icon\chromecast-icon.png" type="BINDATA"
/>
On 2015/05/09 06:37:37, mark a. foltz wrote:
> Does hardware.html have all the icons we need?

No, the hangouts icon isn't available in any of the current iconsets. If it's
not available by the time we add showing specific device types, we can make a
custom icon to use in <core-icon>.

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
chrome/browser/media_router_resources.grdp:35: <include
name="IDR_MEDIA_ROUTER_CHROMECAST_2X_ICON"
file="resources\media_router\elements\icon\chromecast-icon2x.png" type="BINDATA"
/>
On 2015/05/09 06:37:37, mark a. foltz wrote:
> Can you add a patch to chrome/browser/OWNERS to add the committers on the team
> as OWNERS of this file?
> 
> Alternatively could this file be moved to resources/media_router and a new
> OWNERS added there?

I have a patch out for this: https://codereview.chromium.org/1129993003/

From other .grd/.grdp file locations, it seems common for the .grdp file to stay
in the same directory as the .grd file.

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/resourc...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
(right):

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html:50:
<template bind="{{routeMap_[sinkToRouteMap_[sink.id]] as route}}">
On 2015/05/09 06:37:38, mark a. foltz wrote:
> The extra lookup to get the route from the sink makes this template a bit
> complex.
> 
> Another approach would it be to produce a list of [sink, route?] pairs in
> media_router_container.js so that the template can simply iterate over one
list.
> 
> WDYT?

SGTM, this makes another route lookup in media_router_container.js simpler as
well.

[apacible, 2015-05-11 18:36:47]

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
File chrome/browser/media_router_resources.grdp (left):

https://codereview.chromium.org/1133853003/diff/100001/chrome/browser/media_r...
chrome/browser/media_router_resources.grdp:34: <include
name="IDR_MEDIA_ROUTER_CHROMECAST_ICON"
file="resources\media_router\elements\icon\chromecast-icon.png" type="BINDATA"
/>
On 2015/05/11 17:59:48, apacible wrote:
> On 2015/05/09 06:37:37, mark a. foltz wrote:
> > Does hardware.html have all the icons we need?
> 
> No, the hangouts icon isn't available in any of the current iconsets. If it's
> not available by the time we add showing specific device types, we can make a
> custom icon to use in <core-icon>.

Actually, I see "hangout" and "hangout-video" icons under
communication-icons.html. I'm not sure what that looks like, but I'll check it
out when I work on this patch again.

The above comment still applies if it's not the icon we're looking for.

[mark a. foltz, 2015-05-11 23:36:51]

lgtm

[Jeremy Klein, 2015-05-11 23:42:56]

lgtm

Hooray deleted code :-)

[apacible, 2015-05-12 00:39:44]

The CQ bit was checked by apacible@chromium.org

[apacible, 2015-05-12 00:40:23]

On 2015/05/11 23:42:56, Jeremy Klein wrote:
> Hooray deleted code :-)

More code deletion on the way! :)

[commit-bot: I haz the power, 2015-05-12 00:40:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1133853003/140001

[commit-bot: I haz the power, 2015-05-12 02:04:51]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2015-05-12 02:05:55]

Patchset 3 (id:??) landed as
https://crrev.com/0d4b2884a58526ee74fb9b060488cd6fc31c50f3
Cr-Commit-Position: refs/heads/master@{#329312}