Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1133853002: Corrected test that blocked ES3 compressions formats with 2D textures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed check pointed out by zmo@ Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 602d2615f7291fd67118b1cd940dabe38546737f..4cb44a1ac31715f6bea518efc7d51738bad52baa 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -9013,7 +9013,7 @@ bool GLES2DecoderImpl::ValidateCompressedTexDimensions(
"width, height, or depth invalid");
return false;
}
- if (target != GL_TEXTURE_2D_ARRAY) {
+ if (target == GL_TEXTURE_3D) {
LOCAL_SET_GL_ERROR(
GL_INVALID_OPERATION, function_name,
"target invalid for format");
@@ -9115,7 +9115,7 @@ bool GLES2DecoderImpl::ValidateCompressedTexSubDimensions(
{
const int kBlockSize = 4;
GLsizei tex_width, tex_height;
- if (target != GL_TEXTURE_2D_ARRAY ||
+ if (target == GL_TEXTURE_3D ||
!texture->GetLevelSize(target, level,
&tex_width, &tex_height, nullptr) ||
(xoffset % kBlockSize) || (yoffset % kBlockSize) ||
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698