Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 11338030: Improve handling of property loads on the proto chain. (Closed)

Created:
8 years, 1 month ago by Sven Panne
Modified:
8 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Improve handling of property loads on the proto chain. Previously Crankshaft emitted a generic load for these, now we emit a load of a named field, guarded by a proto chain check. LCheckPrototypeMaps now returns the holder, which is for free, because it already had to check its map as the last step, anyway. This is in sync with what StubCompiler::CheckPrototype does. Committed: https://code.google.com/p/v8/source/detail?r=12847

Patch Set 1 #

Patch Set 2 : Fixed holder #

Patch Set 3 : Added unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -29 lines) Patch
M src/arm/lithium-arm.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/proto-chain-load.js View 1 2 1 chunk +12 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
8 years, 1 month ago (2012-10-30 07:49:37 UTC) #1
Sven Panne
Shiny new version of this CL, now with improved holder handling! :-P
8 years, 1 month ago (2012-10-31 10:13:41 UTC) #2
Jakob Kummerow
8 years, 1 month ago (2012-10-31 13:44:28 UTC) #3
LGTM.

I'm not too happy with the fact that "{H,L}CheckPrototypeMaps" are now doing
more than just checking something, but I don't have a good proposal for a better
name -- HCheckPrototypeMapsAndReturnHolder would be a bit clunky.

Powered by Google App Engine
This is Rietveld 408576698