Issue 11338028: Add support for XFWM titlebar buttons.

Issue 11338028: Add support for XFWM titlebar buttons. (Closed)

Created:
8 years, 1 month ago by Lei Zhang

Modified:
7 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add support for XFWM titlebar buttons. BUG=62303

Patch Set 1 : #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+484 lines, -107 lines)			Patch
A	chrome/browser/ui/gtk/DEPS	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_titlebar.cc	View	3 chunks	+3 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/gtk/gconf_titlebar_listener.h	View	2 chunks	+9 lines, -25 lines	0 comments	Download
M	chrome/browser/ui/gtk/gconf_titlebar_listener.cc	View	2 chunks	+41 lines, -69 lines	0 comments	Download
A	chrome/browser/ui/gtk/titlebar_listener.h	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/titlebar_listener.cc	View	1 chunk	+87 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/xfwm_titlebar_listener.h	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/xfwm_titlebar_listener.cc	View	1 chunk	+194 lines, -0 lines	1 comment	Download
M	chrome/chrome_browser_ui.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

satorux: I'm interested in your thoughts on xfwm_titlebar_listener.*. The issue here is the UI thread ...

8 years, 1 month ago (2012-10-30 05:24:38 UTC) #1

satorux1

http://codereview.chromium.org/11338028/diff/6001/chrome/browser/ui/gtk/xfwm_titlebar_listener.cc File chrome/browser/ui/gtk/xfwm_titlebar_listener.cc (right): http://codereview.chromium.org/11338028/diff/6001/chrome/browser/ui/gtk/xfwm_titlebar_listener.cc#newcode103 chrome/browser/ui/gtk/xfwm_titlebar_listener.cc:103: init_event_.Wait(); I'd suggest to call kXfconfGetPropertyMethod asynchronously here. Until ...

8 years, 1 month ago (2012-11-01 04:09:08 UTC) #2

Lei Zhang

7 years, 7 months ago (2013-05-08 04:20:42 UTC) #4

Message was sent while issue was closed.

On 2013/05/08 04:09:16, satorux1 wrote:
> closing as this is very old...

I'll get back to this one someday. :)

Expand Messages | Collapse Messages