Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1133783003: Avoid division-by-zero in SVGLengthContext::convertValueFromUserUnits (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
davve, pdr.
CC:
blink-reviews, krit, kouhei+svg_chromium.org, f(malita), gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Avoid division-by-zero in SVGLengthContext::convertValueFromUserUnits If the viewport is valid but empty, we could end up dividing by zero, which could produce either Infinity or NaN. This could end up triggering an assert when creating a CSSPrimitiveValue for the SVGLength in question. TEST=http/tests/cache/smil-usecounter-in-cached-image.html BUG=485973 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/svg/SVGLengthContext.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
fs
5 years, 7 months ago (2015-05-08 14:43:16 UTC) #2
pdr.
On 2015/05/08 at 14:43:16, fs wrote: > Codechange LGTM I don't see this failing locally ...
5 years, 7 months ago (2015-05-09 04:28:14 UTC) #3
fs
On 2015/05/09 04:28:14, pdr (Slow May 5th - May 18th) wrote: > On 2015/05/08 at ...
5 years, 7 months ago (2015-05-11 08:55:35 UTC) #4
pdr.
On 2015/05/11 at 08:55:35, fs wrote: > On 2015/05/09 04:28:14, pdr (Slow May 5th - ...
5 years, 7 months ago (2015-05-11 09:49:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133783003/1
5 years, 7 months ago (2015-05-11 09:49:26 UTC) #7
fs
On 2015/05/11 09:49:05, pdr (Slow May 5th - May 18th) wrote: > On 2015/05/11 at ...
5 years, 7 months ago (2015-05-11 10:19:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195174
5 years, 7 months ago (2015-05-11 11:08:20 UTC) #9
fs
5 years, 7 months ago (2015-05-11 14:34:41 UTC) #10
Message was sent while issue was closed.
On 2015/05/11 10:19:24, fs wrote:
> On 2015/05/11 09:49:05, pdr (Slow May 5th - May 18th) wrote:
> > On 2015/05/11 at 08:55:35, fs wrote:
> > > On 2015/05/09 04:28:14, pdr (Slow May 5th - May 18th) wrote:
> > > > On 2015/05/08 at 14:43:16, fs wrote:
> > > > > 
> > > > 
> > > > Codechange LGTM
> > > > 
> > > > I don't see this failing locally or on the bots though
> > > >
> >
>
(http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=smi...).
> > > 
> > > Yeah, the odd part is that it shows up in the results for a "later" test
in
> > the same sub-directory:
> > > 
> > >
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
> > > 
> > > sof alerted me to this, and the stacktrace seemed to add up with the
> > smil-usecounter-in-cached-image.html in the same directory. I could repro
when
> > running that test alone in a debug build.
> > 
> > Ahh... I tried running it alone (and with --iterations=100) but for some
> reason
> > it doesn't crash on OSX 10.9.
> > 
> > Looking at the stacktrace... are we running the animation timer for images
> with
> > no users?
> 
> Yes, it appears so. I'll try to look into this (time permitting.)

The timer is triggered by the animation, and the entire scenario (for the assert
to trigger) is likely timing sensitive (too many breakpoints and it no longer
triggers.) Reminds me a bit about the "40 vs. 60 FPS" issue with SVGImage and
animations, where I was pondering if we could control that via the ImageObserver
(and maybe indirectly the clients) somehow. Seems to share some common ground
with not running the animation at all. Haven't been able to move that out of
mind and into code yet though...

Powered by Google App Engine
This is Rietveld 408576698