Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: net/filter/sdch_filter_unittest.cc

Issue 1133763003: SdchObserver: add OnDictionary{Added,Removed} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove manager parameter from SdchObserver Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/filter/sdch_filter_unittest.cc
diff --git a/net/filter/sdch_filter_unittest.cc b/net/filter/sdch_filter_unittest.cc
index 4601d256fecc5eac200a3f549a6c5e9ae2e96832..a83e63ff4c9b0971f97428d432cb2e3a1fcc1d77 100644
--- a/net/filter/sdch_filter_unittest.cc
+++ b/net/filter/sdch_filter_unittest.cc
@@ -1236,8 +1236,7 @@ class SimpleSdchObserver : public SdchObserver {
~SimpleSdchObserver() override { manager_->RemoveObserver(this); }
// SdchObserver
- void OnDictionaryUsed(SdchManager* manager,
- const std::string& server_hash) override {
+ void OnDictionaryUsed(const std::string& server_hash) override {
dictionary_used_++;
last_server_hash_ = server_hash;
}
@@ -1245,10 +1244,12 @@ class SimpleSdchObserver : public SdchObserver {
int dictionary_used_calls() const { return dictionary_used_; }
std::string last_server_hash() const { return last_server_hash_; }
- void OnGetDictionary(SdchManager* /* manager */,
- const GURL& /* request_url */,
+ void OnDictionaryAdded(const GURL& /* dictionary_url */,
+ const std::string& /* server_hash */) override {}
+ void OnDictionaryRemoved(const std::string& /* server_hash */) override {}
+ void OnGetDictionary(const GURL& /* request_url */,
const GURL& /* dictionary_url */) override {}
- void OnClearDictionaries(SdchManager* /* manager */) override {}
+ void OnClearDictionaries() override {}
private:
int dictionary_used_;

Powered by Google App Engine
This is Rietveld 408576698