Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: net/base/sdch_manager.cc

Issue 1133763003: SdchObserver: add OnDictionary{Added,Removed} (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove manager parameter from SdchObserver Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/sdch_manager.cc
diff --git a/net/base/sdch_manager.cc b/net/base/sdch_manager.cc
index c43c8b08c955afa6c441ce5ffbf89408e074abd0..cd702f785d150ddd8c095d5124abc81064b749e1 100644
--- a/net/base/sdch_manager.cc
+++ b/net/base/sdch_manager.cc
@@ -103,7 +103,7 @@ void SdchManager::ClearData() {
blacklisted_domains_.clear();
allow_latency_experiment_.clear();
dictionaries_.clear();
- FOR_EACH_OBSERVER(SdchObserver, observers_, OnClearDictionaries(this));
+ FOR_EACH_OBSERVER(SdchObserver, observers_, OnClearDictionaries());
}
// static
@@ -220,14 +220,14 @@ SdchProblemCode SdchManager::OnGetDictionary(const GURL& request_url,
FOR_EACH_OBSERVER(SdchObserver,
observers_,
- OnGetDictionary(this, request_url, dictionary_url));
+ OnGetDictionary(request_url, dictionary_url));
return SDCH_OK;
}
void SdchManager::OnDictionaryUsed(const std::string& server_hash) {
FOR_EACH_OBSERVER(SdchObserver, observers_,
- OnDictionaryUsed(this, server_hash));
+ OnDictionaryUsed(server_hash));
}
SdchProblemCode SdchManager::CanFetchDictionary(
@@ -448,6 +448,9 @@ SdchProblemCode SdchManager::AddSdchDictionary(
if (server_hash_p)
*server_hash_p = server_hash;
+ FOR_EACH_OBSERVER(SdchObserver, observers_,
+ OnDictionaryAdded(dictionary_url, server_hash));
+
return SDCH_OK;
}
@@ -457,6 +460,9 @@ SdchProblemCode SdchManager::RemoveSdchDictionary(
return SDCH_DICTIONARY_HASH_NOT_FOUND;
dictionaries_.erase(server_hash);
+
+ FOR_EACH_OBSERVER(SdchObserver, observers_, OnDictionaryRemoved(server_hash));
+
return SDCH_OK;
}

Powered by Google App Engine
This is Rietveld 408576698