Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1133763002: Revert of cc: Test BeginMainFrame values come from BeginImplFrame. (Closed)

Created:
5 years, 7 months ago by Kunihiko Sakamoto
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Test BeginMainFrame values come from BeginImplFrame. (patchset #2 id:20001 of https://codereview.chromium.org/1104193003/) Reason for revert: LayerTreeHostTestBeginMainFrameTimeIsAlsoImplTime started failing since a dependent patch (https://codereview.chromium.org/787763006/) is reverted. example: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/24421 Original issue's description: > cc: Test BeginMainFrame values come from BeginImplFrame. > > The frame time in the BeginFrameArgs sent to BeginMainFrame should match a > value from a BeginImplFrame. However there is not a 1:1 relantionship, when the > main thread is slow, there many be multiple impl frames. > > DEPS=http://crrev.com/787763006 > BUG=346230 > R=brianderson,enne > > Committed: https://crrev.com/a003f9bc651a572fea3881cfb72a7d8842c62192 > Cr-Commit-Position: refs/heads/master@{#328929} TBR=brianderson@chromium.org,enne@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=346230 Committed: https://crrev.com/2c7f34a4d97b466b25bb67eb0145036dcede6053 Cr-Commit-Position: refs/heads/master@{#328941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -64 lines) Patch
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +1 line, -64 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kunihiko Sakamoto
Created Revert of cc: Test BeginMainFrame values come from BeginImplFrame.
5 years, 7 months ago (2015-05-08 09:57:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133763002/1
5 years, 7 months ago (2015-05-08 09:57:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 09:58:14 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 09:59:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c7f34a4d97b466b25bb67eb0145036dcede6053
Cr-Commit-Position: refs/heads/master@{#328941}

Powered by Google App Engine
This is Rietveld 408576698