Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1133743004: Make right-most compound check explicit. (Closed)

Created:
5 years, 7 months ago by rune
Modified:
5 years, 7 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make right-most compound check explicit. We set SelectorCheckingContext::elementStyle to null to indicate that we were not in the rightmost compound selector. Use a flag in the context instead to make it clearer what we mean. An alternative would be to have a method inRightmostCompound() on the context instead that checks the elementStyle for nullptr. R=esprehn@chromium.org,timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195606

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M Source/core/css/SelectorChecker.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 15 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rune
5 years, 7 months ago (2015-05-19 12:12:51 UTC) #1
esprehn
I'm not a huge fan of having so many state bits, this means during selector ...
5 years, 7 months ago (2015-05-20 00:34:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133743004/20001
5 years, 7 months ago (2015-05-20 07:05:13 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 09:22:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195606

Powered by Google App Engine
This is Rietveld 408576698