Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1133743003: add guard for future Skia CL https://codereview.chromium.org/1140573004 (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

add guard for future Skia CL https://codereview.chromium.org/1140573004 BUG= Committed: https://crrev.com/f7c815cce35e6def183cd4916c2c32b361b4adc4 Cr-Commit-Position: refs/heads/master@{#330185}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (4 generated)
reed1
5 years, 7 months ago (2015-05-15 18:25:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133743003/1
5 years, 7 months ago (2015-05-15 18:27:29 UTC) #4
Stephen White
https://codereview.chromium.org/1133743003/diff/1/skia/config/SkUserConfig.h File skia/config/SkUserConfig.h (right): https://codereview.chromium.org/1133743003/diff/1/skia/config/SkUserConfig.h#newcode268 skia/config/SkUserConfig.h:268: #ifndef SK_SUPPORT_LEGACY_IMAGEFILTER_TRANSFORM_SCRATCH_LAYTER Is LAYTER correct?
5 years, 7 months ago (2015-05-15 18:27:40 UTC) #5
Stephen White
On 2015/05/15 18:27:40, Stephen White wrote: > https://codereview.chromium.org/1133743003/diff/1/skia/config/SkUserConfig.h > File skia/config/SkUserConfig.h (right): > > https://codereview.chromium.org/1133743003/diff/1/skia/config/SkUserConfig.h#newcode268 ...
5 years, 7 months ago (2015-05-15 18:28:32 UTC) #6
reed1
On 2015/05/15 18:28:32, Stephen White wrote: > On 2015/05/15 18:27:40, Stephen White wrote: > > ...
5 years, 7 months ago (2015-05-15 18:28:54 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 19:41:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1133743003/1
5 years, 7 months ago (2015-05-15 20:16:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 20:23:16 UTC) #12
325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4
Patchset 1 (id:??) landed as https://crrev.com/f7c815cce35e6def183cd4916c2c32b361b4adc4 Cr-Commit-Position: refs/heads/master@{#330185}
5 years, 7 months ago (2015-05-16 05:29:52 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:26:56 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f7c815cce35e6def183cd4916c2c32b361b4adc4
Cr-Commit-Position: refs/heads/master@{#330185}

Powered by Google App Engine
This is Rietveld 408576698