Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: ui/login/oobe.css

Issue 1133733003: Unified icon-buttons used in the new GAIA flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added 'aria-label's. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/oobe.css
diff --git a/ui/login/oobe.css b/ui/login/oobe.css
index f124f899279c24eeb70eb5a208ea96625ce8b356..1d7c7a82cc766cbc049da5b9fb2253088b7ee934 100644
--- a/ui/login/oobe.css
+++ b/ui/login/oobe.css
@@ -34,7 +34,7 @@ button {
/* Follow same focus coloring as in widgets.css */
/* Do not apply this style to restricted button state. */
-button.custom-appearance:not(.button-restricted):not(.button-fancy) {
+button.custom-appearance:not(.button-restricted):not(.button-fancy):not([is="gaia-icon-button"]) {
Greg Levin 2015/05/08 19:18:07 This change (?) has removed the blue focus rectang
dzhioev (left Google) 2015/05/08 21:15:45 Nice catch! Adding attribute selector increased th
michaelpg 2015/05/08 22:02:22 I don't think we technically have a line length li
dzhioev (left Google) 2015/05/08 22:29:02 We do have a limit, 80 characters as usual.
michaelpg 2015/05/08 22:33:39 Ah ok. Can you point me to the style guide?
Greg Levin 2015/05/11 14:33:50 I don't really know css syntax, but experimentally
dzhioev (left Google) 2015/05/11 23:05:58 Done, split line after ":not("
-webkit-transition: border-color 200ms;
border: 1px solid transparent;
/* Don't grey out disabled buttons. */

Powered by Google App Engine
This is Rietveld 408576698